test(cbor): remove map null value in test assertion #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description says "Clients SHOULD tolerate seeing a null value in a dense map, and they SHOULD drop the null key-value pair." This means the expected params.denseSetMap should not retain the null value present in the base64 payload.
kstich
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cbor protocol test appears to have an extraneous value in its result matcher.
The description says "Clients SHOULD tolerate seeing a null value in a dense map, and they SHOULD drop the null key-value pair." This means the expected
params.denseSetMapshould not retain the null value present in the base64 payload.Testing
Tested this change while building Smithy RPCv2 CBOR for TypeScript - smithy-lang/smithy-typescript#1280